Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !22421

Update nav and navbar HTML markup

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/tagliala/update-navs-markup into v4-dev Apr 12, 2017
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 3

Created by: tagliala

According to the docs, you just need to apply the navbar-nav to an <ul> tag in a list-based navbar. In fact, navbar-nav seems to override all the css properties set by nav.

Also, nav-item class should be used only for <li> tags, or in conjunction with <a> tags to entirely avoid the list-based approach.

This commit removes the redundant nav class from navbar-nav <ul> tags, moves nav-item from <a> tags to <li> tags and properly adds nav-item class to <li> tags where missing.

Refs:

  • https://v4-alpha.getbootstrap.com/components/navs/
  • https://v4-alpha.getbootstrap.com/components/navbar/#nav
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tagliala/update-navs-markup