Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !22436

cover popover arrow when title is present

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/IdanCo/bugfix/popover-with-title-arrow-color into v4-dev Apr 13, 2017
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: IdanCo

Summary

Following issue #22432 (closed) and PR #22433 , change the arrow color of popover when title is present - image

See it in action here - http://jsbin.com/tubuwu/edit?html,output

Before

Arrow color was the same, regardless of the presence or absence of a title in the popover

After

Arrow color is now dependent on the presence or absence of a title in the popover

Technical

I've used an existing pseudo element of the title, originally intended to fix a gap between the popover and the arrow, and redesigned it to cover the arrow entirely with the title's background color.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/IdanCo/bugfix/popover-with-title-arrow-color