Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !22706

Revert simplified grid column styles from #22376

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge revert-22376 into v4-dev May 26, 2017
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

The premise for #22376 was that if we removed the max-width and flex properties, we could use the column classes as width utilities. The problem that I didn't remember at the time is that column classes have horizontal padding on them. This doesn't work for setting width. Perhaps more importantly, this causes #22649 (closed)—the automatic sizing of columns is broken with the absence of flex styles.

/cc @sachinsinghi

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: revert-22376