Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !22821

v4: Remove the confusing _custom.scss file

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge rip-custom into v4-dev Jun 14, 2017
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 4

Original issue: #17322 (closed). Original PR: #18398.

Honestly, this one is more pain than it's worth. Looking back, the file was originally added because I had left a comment in the variables file that you could copy-pasta some lines into that file for easier customization. I don't think that's a helpful way forward for a few reason:

  • It's been brought up in so many issues.
  • We flipped how it's used, by changing the import order (and then back again) after it screwed up some other stuff.
  • In the current implementation, you cannot use other variables in the custom file—only copy-paste and change the values of existing ones. So, for example, you cannot add $my-new-var: $blue.

Nuking it in favor of relying on imports from package manager directories (where you're most likely to be using source Sass files) and manual forks of the project.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rip-custom