Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !22950

Card styles

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge more-card-less-card into v4-dev Jun 30, 2017
  • Overview 0
  • Commits 8
  • Pipelines 0
  • Changes 7

This PR changes how we do card variants. Rather than generate custom classes for just the .card component for changing the color, background-color, and border-color, we're now using our utility classes. This provides more flexibility in how you ultimately style cards, while at the same time reducing our compiled CSS.

  • Drops all card mixins. No more need for a .card-dark—which also coincidentally conflicted with .card-dark from the $theme-colors Sass map—and no more card-variant or card-outline-variant.

  • Replaces all .card-{color} instances with a mix of .bg-{color} and .text-white as needed. For the outline ones, we're now using .border-{color}.

  • Drops the .card-blockquote ahead of #22949 shipping, which removes most of the styling that we were overriding with that class. Might need some margin utilities still, though.

Docs have been updated, but might need to update the migration guide, too.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: more-card-less-card