Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !23260

Sass map trickery for easier customization

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge merge-color-maps into v4-dev Aug 09, 2017
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 1

Peep the CodePen demo.

This PR creates a !default empty Sass maps for our $grays, $colors, and $theme-colors lists and map-merges a default setting for all colors into them. This way, anyone can continue to map-merge in additional or replacement key: value pairs as needed without having to replace the entire original Sass map as @martinbean pointed out in #23112 (closed).

This technique was pointed out by @hokiecoder in https://github.com/twbs/bootstrap/issues/22891#issuecomment-316463806.


Thoughts? If folks are interested, we'll need to update the options.md docs page to explain this, and add some code comments in our Sass files.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: merge-color-maps