Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !23435

Adds component disabled color variable to improve consistency

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/andresgalante/disabled-color into v4-dev Aug 14, 2017
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: andresgalante

This is a suggestion to improve consistency

There are several components that have definitions for disabled state color:

$btn-link-disabled-color:                    $gray-600 !default;
$custom-control-description-disabled-color:  $gray-600 !default;
$custom-select-disabled-color:               $gray-600 !default;
$dropdown-link-disabled-color:               $gray-600 !default;
$nav-link-disabled-color:                    $gray-600 !default;
$pagination-disabled-color:                  $gray-600 !default;
$list-group-disabled-color:                  $gray-600 !default;

// these are different
$navbar-dark-disabled-color:        rgba($white,.25) !default;
$navbar-light-disabled-color:       rgba($black,.3) !default;

What about adding a $component-disabled-color to define the disabled state colors?

$component-disabled-color:  $gray-600 !default;

What do you think?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/andresgalante/disabled-color