Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !23673

Changes alerts close btn to improve accessibility

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/andresgalante/improves-alerts into v4-dev Aug 25, 2017
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: andresgalante

Changes alerts close btn position on the markup to improve accessibility

This PR is a simple order change of the close btn on alerts that improves the way a screen reader reads them.

Instead of going:

"Close, Holy guacamole! You should check in on some of those fields below, alert, Close, button"

now it goes:

"Holy guacamole! You should check in on some of those fields below, Close, alert, Close, button"

Which IMO it makes more sense.

Plus:

  • If the notification has an a a screen reader will tab order first the link then the close btn
  • this solution is more flexible since the user can put the btn markup anywhere and it'll render always on the top right corner disregarding the amount of text that the alert has.

Fixes #21889 (closed).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/andresgalante/improves-alerts