Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !23718

Fix unwanted body padding when a modal is opened

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/valerie-makes/fix-unwanted-padding-on-modal into v4-dev Aug 28, 2017
  • Overview 0
  • Commits 7
  • Pipelines 0
  • Changes 2

Created by: valerie-makes

Fixes #23681 (closed)

This prevents padding being added to the body when it's not overflowing but has a margin (e.g. the default 8px) by measuring its outer width (i.e. including the margin).

@Johann-S:

if it's isn't possible to test that with Phantomjs a visual test would be a solution

The problem is that this is breaking other existing PhantomJS tests... but as stated before, it works fine when running those same tests in Chrome.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/valerie-makes/fix-unwanted-padding-on-modal