Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !23748

V4 variable reuse

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/joneff/v4-variable-reuse into v4-dev Aug 30, 2017
  • Overview 0
  • Commits 11
  • Pipelines 0
  • Changes 5

Created by: joneff

In a nutshell:

  • extract color-yiq mixin to a generic contrast-yiq function to be used for ensuring contrast;
  • introduce $component-* variables linked to $body- variables;
  • link the following to $body- vars:
    • input; rationale: usually have the same background as body;
    • table; rationale: transparent background; usually sit against body;
  • link the following to $component- vars:
  • card, dropdowns, list groups, modals and popovers; rationale: one might want to change all components at once
  • ensured contrast:
    • in input, tooltip and progressbar, between text and background
    • in table, for adequate hover / active background (with opacity)
    • in the rest of the components, for adequate border color (with opacity)

Few notes:

  • with the current variable set, the output will not be changed. It's only when one starts to play around;
  • while modal and cards have a dedicated color for background, they lack one for color. In terms, it's inherited from the nearest ancestor;

Related to https://github.com/twbs/bootstrap/issues/23595

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/joneff/v4-variable-reuse