Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !23783

Increases clickable area of the close btn on modals

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/andresgalante/modal-close-btn into v4-dev Aug 31, 2017
  • Overview 0
  • Commits 4
  • Pipelines 0
  • Changes 1

Created by: andresgalante

On alerts we increase the clickable area of the close btns to make them easier to click on devices where the pointer is coarse and improve accessibility.

This PR does 2 things:

1- Introduces the same concept for modals. 1- Changes the align-items to flex-start so the close btn always stays on the upper right corner when the modal-title text wraps.

I am not sure if this should be a global change on _close.scss

What do you think?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/andresgalante/modal-close-btn