Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !23906

Adds nav tag around navs examples

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/andresgalante/accecible-navs into v4-dev Sep 10, 2017
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: andresgalante

This PR closes #23831 (closed) it adds a <nav> tag around Navs snippets.

@patrickhlauke I am in the fence with this one, I thought it was a great idea but now that I think about it, users might end up adding navs everywhere on their document even though their navs are not used as navigation. On the other hands chances are that navs are mostly use for navigation. If you think the accessibility notes are enough, please close this PR, and as always thanks a lot for the review, I learn a lot from them 😄

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/andresgalante/accecible-navs