Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !23907

Accessibility fixes to dynamic tabs (`aria-selected`, remove dynamic tabs with dropdowns)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Patrick H. Lauke requested to merge github/fork/patrickhlauke/v4-dev-tabs-a11y-fix into v4-dev Sep 10, 2017
  • Overview 0
  • Commits 7
  • Pipelines 0
  • Changes 3
  • Fixes our current incorrect use of aria-expanded rather than the proper aria-selected (see https://www.w3.org/TR/wai-aria-practices/#tabpanel)
  • Removes dynamic tabbed interfaces with dropdowns, as they're not good for usability and more importantly not a pattern that can be expressed/conveyed to assistive tech

Closes #23035 (closed) Further closes #23903 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/patrickhlauke/v4-dev-tabs-a11y-fix