Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !24132

prevent empty carousel from throwing, and staying in a 'sliding' state

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/jimmymain/v3.4.0-dev into v3.4.0-dev Sep 27, 2017
  • Overview 0
  • Commits 4
  • Pipelines 0
  • Changes 1

Created by: jimmymain

There are numerous questions on stack overflow relating to how the carousel becomes broken when it is emptied for any reason. This makes binding slides using angular or similar technologies very difficult, as they will routinely replace the set of slides with a new set.

whist I believe that calling $.carousel() should reset all the settings (particularly the sliding state), this simpler tweak at least ensures that if you use an angular / react binding to the carousel and it becomes empty, it does not get stuck in a sliding state.

please consider this pull - or something similar.

  • https://stackoverflow.com/questions/29027830/getting-cannot-read-property-offsetwidth-of-undefined-with-bootstrap-carousel
  • https://stackoverflow.com/questions/35918723/bootstrap-carousel-controls-causing-error
  • https://stackoverflow.com/questions/29027830/getting-cannot-read-property-offsetwidth-of-undefined-with-bootstrap-carousel
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jimmymain/v3.4.0-dev