Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !24240

Fix modal bug

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge v4-dev-24240 into v4-dev Oct 04, 2017
  • Overview 0
  • Commits 12
  • Pipelines 0
  • Changes 2

Created by: ghost

Fixes #24117 (closed).

Note that the hide() function checks, before executing the routine, that the modal is not hidden. This is logical: why should I try to hide something that is already hidden?

hide(event) {
  if (this._isTransitioning || !this._isShown) {
    return
  }
}

However, the show() function does not do this same check and runs the entire routine even though the modal is visible.

show(event) {
  if (this._isTransitioning) {
    return
  }
}

That is why I check, before running the whole routine, that the modal is not visible. And I have verified that this indeed solves the bug.

PS: Sorry for the English. I'm using Google Translator.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: v4-dev-24240