Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !24241

npm scripts: quote globs.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged XhmikosR requested to merge v4-dev-xmr-npm-scripts into v4-dev Oct 04, 2017
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 7

OK this was very annoying and was driving me crazy.

I had noticed for a long time that htmlhint on Travis said, 13 HTML files scanned without any errors. That was clearly wrong since we have a lot more HTML files.

Then I noticed that after the stylelint switch, Travis builds would sometimes be marked as passed when locally I was getting errors.

So, for anyone reading this, always quote your globs in npm scripts.

PS. this is the reason htmlhint was basically not doing anything.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: v4-dev-xmr-npm-scripts