Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !24315

Reduce z-indexes in button-group, input-group, list-group, and pagination to the minimum necessary

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/rmacklin/reduce-z-indexes-to-minimum-necessary into v4-dev Oct 09, 2017
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 5

Created by: rmacklin

These were using z-index: 2 to "Place active items above their siblings for proper border styling". However, using z-index: 1 is sufficient for accomplishing that goal.

In input-group, there were also three z-index: 3 rules for the hover/focus/active states. I reduced these to z-index: 2 since they just needed to be "one more than normal" (i.e. one more than what is now z-index: 1 after my changes).

These changes can be verified by viewing the documentation pages for Button group, Input group, List group, and Pagination before and after this commit and observing that the active elements are still "above" their siblings, so their borders look correct. (In fact, the easiest way may just be to change these z-indexes in the dev tools style editor - that's what I did before opening this PR.)

I also added a brief paragraph in the documentation about these z-indexes.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/rmacklin/reduce-z-indexes-to-minimum-necessary