Skip to content
GitLab

WIP: Simplifies and improves table backgrounds

Closed Administrator requested to merge v4-dev-andres-table-active-state into v4-dev

Created by: andresgalante

This PR is needs more clean up and better organization, but bare with me.

The way we use selectors for background on tables doesn't allow to have a different colors within a row, for example:

    <tr class="table-danger">
        <th scope="row">9</th>
        <td>Column content</td>
        <td class="table-warning">Column content</td>
        <td>Column content</td>
      </tr>

It also doesn't allow to mark something as active like this:

      <tr class="table-danger">
        <th scope="row">9</th>
        <td>Column content</td>
        <td class="table-active">Column content</td>
        <td>Column content</td>
      </tr>

or to mark something as active within an active row like this:

      <tr class="table-active">
        <th scope="row">9</th>
        <td>Column content</td>
        <td class="table-active">Column content</td>
        <td>Column content</td>
      </tr>

... and it produces issues like the one described on #24529 (closed)

By simplifying the selectors it resolves it and I don't see conflicts with nested tables or .table-striped. I tried to digg up the history of this selector but I couldn't find the root.

@mdo @XhmikosR Can you please point me out what I am missing so I can continue with this PR?

Thanks a lot!

This is a WIP but when it's done it will close #24529 (closed)