Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !24686

Switch to cssnano.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed XhmikosR requested to merge v4-dev-xmr-cssnano into v4-dev Nov 06, 2017
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 3

OK, this is something I've been meaning to try out for a long time.

With the first patch, results are pretty much the same except for CSS pseudo elements reduced to pseudo classes like ::after -> :after. Browsers shouldn't have any issue with that.

The second patch is using the default preset which does selector merging (should be OK), transforms reducing (translate3d to transform{x,y,z) if shorter; this one we need to verify), completely removes quotes from font names (this should be OK based on the specs, although traditionally we use quotes for spaces in names).

The gain isn't huge, especially if we go with the first patch. Still the fact that the sourcemaps are OS independent is one plus currently compared to clean-css.

/C @ben-eb for any thoughts/suggestions.

PS. The reason I went with the postcss plugin solution is that there is no v4.x of the cssnano available yet.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: v4-dev-xmr-cssnano