Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !2481

Fixed size reset for collapses in IE (and other browsers which does not supporttransitions)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/pelme/collapse_reset_fix_ie into 2.0.2-wip Mar 09, 2012
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: pelme

reset() is called after the collapsible content has been resized by a transition, to set the width or height to auto.

Practically, this means that .collapse gets a fixed height in IE, so any content that changes its height will overflow the collapse instead of the collapse adjusting its size.

However, when transitions are not supported, the reset() callback is called immediately, which causes the reset to take place BEFORE the width/height change it is supposed to reset. This makes the reset() call useless, since the content gets the static width/height anyways.

This changes uses setTimeout to make sure that the reset() callback is called after the width/height is set.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/pelme/collapse_reset_fix_ie