Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !25164

Print tweaks

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge print-tweak into v4-dev Jan 02, 2018
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 2

Adds two new variables for printing—page size and min-width for the <body> and .container. Using the docs homepage as my example, this printed the most similar in macOS Chrome and Safari. I'll check in on Windows browsers before merging.

While working on this, a few things came to light:

  • Safari doesn't respect @page's size, hence the min-widths.
  • Chrome is super finicky with @page. Adding margin or !important broke the size property.

I'm expecting even more issues across other browsers as I get into them.

Hopefully fixes #23864 (closed) and fixes #23992 (closed).

/cc @tigermarques @michaelkrieger

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: print-tweak