Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !25823

Fix scrollspy test on firefox (v4 without jquery)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/alekitto/v4-without-jquery into v4-without-jquery Mar 10, 2018
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: alekitto

Related to https://github.com/twbs/bootstrap/pull/23586#issuecomment-371472645 Seems that jQuery position() method calculates position including sub-pixels on firefox and returning floating point numbers as offsets, while native offsetTop property does not. Maybe should we remove jQuery from our unit tests and add some compatibility tests using the jQuery interface?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/alekitto/v4-without-jquery