Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !26916

Fix custom file input z-index

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/MartijnCuppens/fix-custom-file-input-z-index into v4-dev Jul 18, 2018
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: MartijnCuppens

Fixes #26912 (closed).

What happend? Box-shadow of custom file inputs are added to the label instead of the input itself. The z-index of the label was increased to overlap buttons (see #26361), but the z-index of the custom file input didn't increase. Therefore the label was clicked and this focuses the file input, but didn't trigger the file browser.

The fix I've increased the z-index of the custom file input so that the file input works again.

Demo: https://codepen.io/MartijnCuppens/pen/qyaZzv

Tested in latest Chrome/Firefox/IE/Edge/Safari

Kudos to @ysds for adding the ticket number in his commit, this made it a lot easier to find out what was wrong

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/MartijnCuppens/fix-custom-file-input-z-index