Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !27155

Boom toasted

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Lausselloic/boom-toasted into boom-toasted Aug 30, 2018
  • Overview 0
  • Commits 5
  • Pipelines 0
  • Changes 4

Created by: Lausselloic

Hello, @Johann-S I've improve some part of the toaster

  • improve accessibility by adding role="alert" aria-live="assertive" aria-atomic="true" on samples and write some more details onto how make it more accessible (maybe need an english review @patrickhlauke )

  • also for accessibility, I think it's really better to let user control the toaster and close it by itself (otherwise AT will vocalise the content but the user can't find it into the page) maybe need a way to inform the user with AT that's an autoclosed component? Haven't find a good idea with aria :-(

  • update the hide method to close toaster immediatly on click, implement data-dismiss="toast" like for modal

  • add a unit test for that purpose

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Lausselloic/boom-toasted