Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !27339

Add new `.rounded-pill` utility

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/sts-ryan-holton/add-rounded-pill-feature into v4-dev Sep 29, 2018
  • Overview 0
  • Commits 37
  • Pipelines 0
  • Changes 3

Created by: sts-ryan-holton

This PR adds a new .rounded-pill class as per MDO's comment on https://github.com/twbs/bootstrap/issues/26442 and also adds a new .btn-rounded class to the buttons component (https://getbootstrap.com/docs/4.1/components/buttons/)

Essentially, I've made a reusable mixin which is then applied to both the .rounded-pill and btn-rounded classes. I felt it wouldn't make sense to simply apply a .rounded-pill class directly to a .btn as MDO has mentioned in many conferences about creating modifier classes, it only makes logical sense to then create a .btn-rounded class to follow this structure.

This PR also updates the docs with these new classes 👍

Hoping we can add this into Bootstrap 4.2, and hope to see it as a useful feature as I received positive community upvotes with this ❤️

/CC @XhmikosR @mdo

Fixes #26442 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/sts-ryan-holton/add-rounded-pill-feature