Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !27457

Make jquery and popper.js dependencies

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/perrin4869/dependencies into v4-dev Oct 17, 2018
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: perrin4869

Reading through issues, https://github.com/twbs/bootstrap/issues/23204 where it was decided to make jQuery and popper.js peer dependencies, I think that the main reason for the decision was to minimize the number of packages installed by npm. However, peerDependencies are required too, and emit a warning if they are not found... they are not really optional, so it does not solve the problem. Also, peer dependencies are mostly designed for cases like when using react-router, you will inevitably be using react too... but in this case, chances are that even if you use bootstrap, you will not be using those other 2 dependencies on their own. Moreover, both jQuery and popper.js are marked as external in https://github.com/twbs/bootstrap/blob/v4-dev/build/rollup.config.js, so they are not really bundled in. In a way they could even be considered devDependencies, because neither package is used in practice... but in principle they are imported in the source files, so they are technically normal deps. This is not a breaking change, since it does not change the usage of the package in any way.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/perrin4869/dependencies