Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !27982

WIP: Use husky to execute linters

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge v4-dev-martijncuppens-husky into v4-dev Jan 05, 2019
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: MartijnCuppens

Closes #27973 (closed)

The linting taks are now ran before anything is pushed which will help us with builds that fail because of trivial lint errors.

I preferred the pre-push option above the pre-commit option because all linting tasks take about 9 seconds to complete which could be annoying.

This PR also contains a commit which parallelizes the linting tasks. This decreases the time from around 9 seconds to 4-5 seconds.

Not sure if we should add the --fix command which automatically fixes fixable linting errors (like fixing the property order). Maybe we could add an additional command for it?

TODO:

  • Add documentation once we've decided how we're going to implement it.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: v4-dev-martijncuppens-husky