Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !28500

v5: Simplify docs CSS build and tasks

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Mark Otto requested to merge v5-docs-css into master Mar 15, 2019
  • Overview 0
  • Commits 4
  • Pipelines 0
  • Changes 2

Currently the docs include Bootstrap's built CSS via css-copy task, duplicating the dist/css/ directory into site/static/docs/4.3/dist/css/. This task is currently busted in master for some reason, but it reminded me that there's likely a simpler way.

We already import the functions, variables, and mixins into docs.scss—so why not simply include all of Bootstrap? That's what this PR suggests. We're still generating the dist files, but this reduces the number of stylesheets in our docs and saves some npm tasks.

Any concerns about doing it this way? I'm not 100% sure yet, but doing this might mean I'm currently missing some tasks that get run on the dist copy but not the docs copy? And what about dist/js/—can we make the same improvements somehow?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: v5-docs-css