Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !28696

Change custom file markup

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/ysds/custom-file-markup into master Apr 26, 2019
  • Overview 0
  • Commits 5
  • Pipelines 0
  • Changes 4

Created by: ysds

Please see https://github.com/twbs/bootstrap/pull/28511#issuecomment-474381351.

By changing the markup of custom file, remove the way of translating button labels by CSS, and support a long file name. Now, you can change the button label by HTML.

And for fix #28389 (closed), move the border to the each children of the .custom-file-label. Another way by overflow: hidden is suddested (https://github.com/twbs/bootstrap/pull/28388#issuecomment-468898020), but it does not round the inside of the corner.

2019-04-28

I also added the transition to .custom-file-text and .custom-file-button for focused border color animation.

Closes #25497 (closed) Closes #26933 (closed) Closes #28388 Closes #28389 (closed)

Preview: https://deploy-preview-28696--twbs-bootstrap.netlify.com/docs/4.3/components/forms/#file-browser

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ysds/custom-file-markup