Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !28855

Workaround for the image size bug in IE

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge master-ysds-image-in-card into master Jun 01, 2019
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 1

Created by: ysds

Fixes #22448 (closed) Fixes #28839 (closed)

See https://github.com/philipwalton/flexbugs/issues/75

In IE 11, though, it appears to size the image correctly, but the surrounding body div sizes up its height (never collapses) as if the full height of the source image were there.

Adding min-height: 1px to the flex item does, in fact, work around the issue. There's some sort of sorcery going on here in IE's guts. My best guess is that the min-height forces IE to recalculate the height of the rendered content after all of the resizing, and that makes it realize that the height is different.

Demo: https://codepen.io/fellows3/pen/QRJmmx Left: Chrome / Right: IE11

image

The min-height: 1px fixes that, but my concern is this affects unexpected parts (or not). At least there is no problem with accordions.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-ysds-image-in-card