Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !28896

tooltip dispose:removing only own event handler

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/david-lallement/tooltip-dispose into master Jun 12, 2019
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: david-lallement

If the tooltip component is in a modal, only the listeners created by the tooltip component should to be removed in the dispose method. For example, if we subscribe to the hide.bs.modal event of the modal component and call the dispose method of a tooltip component inside, the hide.bs.modal event subscription is lost.

Using of event namespace feature of jquery ensures that only the handler created in _setListeners function is removed in dispose function.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/david-lallement/tooltip-dispose