Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !29322

v5: .form-check layout changes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge more-checks into master Aug 29, 2019
  • Overview 0
  • Commits 8
  • Pipelines 0
  • Changes 5
Screen Shot 2019-08-28 at 9 08 36 PM

This PR does a few things:

  • Scopes .form-check-input layout properties to the .form-check parent, allowing easy placement of the .form-check-input in more places.
  • Updates the no-label checks. Current version recommends static positioning, but we use floats, so this is kinda busted right now.
  • Updates the checkbox/radio in input group example to use the v5 style .form-check-input.
  • Documents how to use .form-check within list groups. This also includes the addition of margin-bottom: 0 on list group items so you can use the <label> element.

Fixes #28524 (closed), closes #28603 (closed) (though this is outdated by v5's combined .form-check). Also closes #28242 (closed).

Preview: https://deploy-preview-29322--twbs-bootstrap.netlify.com/

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: more-checks