From be28654726114d813ac3464e532917e9f6f9c1fe Mon Sep 17 00:00:00 2001 From: XhmikosR <xhmikosr@gmail.com> Date: Sat, 5 Oct 2019 16:04:56 +0300 Subject: [PATCH 1/5] Drop support for Node.js 8. By the time v5 stable will be out, 8 will be EOL (December 2019). --- .github/workflows/test.yml | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 27739bf86c..1506021dea 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -9,7 +9,7 @@ jobs: strategy: fail-fast: false matrix: - node: [8, 10, 12] + node: [10, 12] steps: - name: Clone repository diff --git a/package.json b/package.json index bb4bc810ea..35b782b902 100644 --- a/package.json +++ b/package.json @@ -137,7 +137,7 @@ "vnu-jar": "19.9.4" }, "engines": { - "node": ">=8" + "node": ">=10" }, "files": [ "dist/{css,js}/*.{css,js,map}", -- GitLab From 3f739908925b9116e292c138a3f5f598b051d0b3 Mon Sep 17 00:00:00 2001 From: XhmikosR <xhmikosr@gmail.com> Date: Sat, 5 Oct 2019 16:12:13 +0300 Subject: [PATCH 2/5] Test with a .nvmrc file --- .nvmrc | 1 + 1 file changed, 1 insertion(+) create mode 100644 .nvmrc diff --git a/.nvmrc b/.nvmrc new file mode 100644 index 0000000000..f599e28b8a --- /dev/null +++ b/.nvmrc @@ -0,0 +1 @@ +10 -- GitLab From 44738e40b88d552859bdb05d7bef693837eb735b Mon Sep 17 00:00:00 2001 From: XhmikosR <xhmikosr@gmail.com> Date: Sun, 6 Oct 2019 11:04:10 +0300 Subject: [PATCH 3/5] Revert "Test with a .nvmrc file" --- .nvmrc | 1 - 1 file changed, 1 deletion(-) delete mode 100644 .nvmrc diff --git a/.nvmrc b/.nvmrc deleted file mode 100644 index f599e28b8a..0000000000 --- a/.nvmrc +++ /dev/null @@ -1 +0,0 @@ -10 -- GitLab From b4d5bae4559dc46cad607636a6ea87e8a3df86c6 Mon Sep 17 00:00:00 2001 From: XhmikosR <xhmikosr@gmail.com> Date: Wed, 9 Oct 2019 01:40:21 +0300 Subject: [PATCH 4/5] Update test.yml --- .github/workflows/test.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 96d74522ca..46186a5b2a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -36,20 +36,20 @@ jobs: - name: Run bundlesize run: npm run bundlesize - if: matrix.node == 10 + if: matrix.node == 12 env: BUNDLESIZE_GITHUB_TOKEN: "${{ secrets.BUNDLESIZE_GITHUB_TOKEN }}" - name: Run BrowserStack tests run: npm run js-test-cloud - if: matrix.node == 10 && github.repository == 'twbs/bootstrap' && github.event_name == 'push' + if: matrix.node == 12 && github.repository == 'twbs/bootstrap' && github.event_name == 'push' env: BROWSER_STACK_ACCESS_KEY: "${{ secrets.BROWSER_STACK_ACCESS_KEY }}" BROWSER_STACK_USERNAME: "${{ secrets.BROWSER_STACK_USERNAME }}" - name: Run Coveralls run: npm run coveralls - if: matrix.node == 10 && github.repository == 'twbs/bootstrap' && github.event_name == 'push' + if: matrix.node == 12 && github.repository == 'twbs/bootstrap' && github.event_name == 'push' env: COVERALLS_REPO_TOKEN: "${{ secrets.COVERALLS_REPO_TOKEN }}" COVERALLS_GIT_BRANCH: "${{ github.ref }}" -- GitLab From 4699b1a220b0d51d45552eab4c43811fa5d68bcc Mon Sep 17 00:00:00 2001 From: XhmikosR <xhmikosr@gmail.com> Date: Wed, 9 Oct 2019 11:07:09 +0300 Subject: [PATCH 5/5] Update test.yml --- .github/workflows/test.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 46186a5b2a..96d74522ca 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -36,20 +36,20 @@ jobs: - name: Run bundlesize run: npm run bundlesize - if: matrix.node == 12 + if: matrix.node == 10 env: BUNDLESIZE_GITHUB_TOKEN: "${{ secrets.BUNDLESIZE_GITHUB_TOKEN }}" - name: Run BrowserStack tests run: npm run js-test-cloud - if: matrix.node == 12 && github.repository == 'twbs/bootstrap' && github.event_name == 'push' + if: matrix.node == 10 && github.repository == 'twbs/bootstrap' && github.event_name == 'push' env: BROWSER_STACK_ACCESS_KEY: "${{ secrets.BROWSER_STACK_ACCESS_KEY }}" BROWSER_STACK_USERNAME: "${{ secrets.BROWSER_STACK_USERNAME }}" - name: Run Coveralls run: npm run coveralls - if: matrix.node == 12 && github.repository == 'twbs/bootstrap' && github.event_name == 'push' + if: matrix.node == 10 && github.repository == 'twbs/bootstrap' && github.event_name == 'push' env: COVERALLS_REPO_TOKEN: "${{ secrets.COVERALLS_REPO_TOKEN }}" COVERALLS_GIT_BRANCH: "${{ github.ref }}" -- GitLab