Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !29516

Added animation when modal backdrop is static

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/anjoshigor/modal-backdrop-static into master Oct 12, 2019
  • Overview 0
  • Commits 19
  • Pipelines 0
  • Changes 5

Created by: anjoshigor

The problem

When the modal backdrop is static, it should not hide when user clicks outside it or press escape key. But the current behavior wasn't in agreement with this requisite.

more info on issue #26704 (closed)

The solution

  • When the event KEYDOWN_DISMISS is fired, the static property is verified and another event HIDE_PREVENTED is fired.
  • The event, if not prevented, is handled and a 1.2 scale transition is performed.
  • If anyone wants to ovewrite this behavior, he/she should listen to the new HIDE_PREVENTED event and handle it accordingly.

Evidence

backdrop

Any doubts and suggestion, please contact! 🤘

P.S: I'm planning to update doc in another PR.

Preview: https://deploy-preview-29516--twbs-bootstrap.netlify.com/docs/4.3/components/modal/#static-backdrop

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/anjoshigor/modal-backdrop-static