Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !29753

Improve build/generate-sri.js regex

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Noah2610/fix/generate-sri-regex into main Nov 27, 2019
  • Overview 1
  • Commits 10
  • Pipelines 0
  • Changes 1

Created by: Noah2610

When using single-quotes in config.yml, the previous regular expression in build/generate-cli.js wasn't working correctly, it was replacing ALL string values with hashes. Now both double- and single-quotes can be used in config.yml, and the RegExp will work as expected.


I have tested the script with both ' and " used in config.yml, and it seems to work properly! The changes to config.yml haven't been committed, though.

Fixes #29741 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Noah2610/fix/generate-sri-regex