Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !29870

Placeholder for transitions reset to prevent code duplication for #29862

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/ffoodd/feature/reduced-motion-redundancy into master Dec 17, 2019
  • Overview 4
  • Commits 25
  • Pipelines 0
  • Changes 5

Created by: ffoodd

As mentionned in #29862 (closed), resetting globally animations and transitions is too risky — but we can still reduce redundancy by using a placeholder.

It also allow resetting transitions without using the transition() mixin, by simply extending the placeholder.

And it's far from useless, comparing the results of npm run bundlesize locally:

File master Pull Request
bootstrap.css 22.47 kb 22.23 kb
bootstrap.min.css 20.93 kb 20.71 kb

I'd be pleased to dicuss this, and thanks @MartijnCuppens and @patrickhlauke for your comments — I'll update my fork accordingly :)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ffoodd/feature/reduced-motion-redundancy