Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !29908

package.json: remove engines property

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged XhmikosR requested to merge master-xmr-pck-rm-engines into master Dec 24, 2019
  • Overview 3
  • Commits 3
  • Pipelines 0
  • Changes 1

This property doesn't, or shouldn't, affect consumers of the npm package since we distribute the built files.

IMO we should definitely backport this to v4-dev, that's the whole point, but it could be considered a breaking change, although I don't see exactly how. So, please chime in if you think this could break something out there.

Closes #29821 (closed)

TODO:

  • verify Netlify picks up the proper Node.js version - it's using Node.js 10.x AFAICT, like before
  • decide if we should backport this to v4-dev
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-xmr-pck-rm-engines