Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !30009

Use variables for list-group-item color levels

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/yankee42/list-group-item-color-level-variables into master Jan 13, 2020
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: yankee42

The color levels used in alerts: https://github.com/twbs/bootstrap/blob/c13ec3ea937c21994f5cffc1d759869af6747227/scss/_alert.scss#L49

And in tables: https://github.com/twbs/bootstrap/blob/c13ec3ea937c21994f5cffc1d759869af6747227/scss/_tables.scss#L105

Come from a variable. However the color level for list-group-item is hard coded: https://github.com/twbs/bootstrap/blob/c13ec3ea937c21994f5cffc1d759869af6747227/scss/_list-group.scss#L159

This does strike me as inconsistent. I think all these options should be equally customizable. This PR fixes this by also putting the color levels for list-group-items into a variable.

Also note, that the default value for alert&table are both -10 and 6 for background and color respectively. However the defaults for list-group-item ist -9 and 6 for background and color respectively. I did not change this (yet) as I am not sure whether this might be on purpose.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/yankee42/list-group-item-color-level-variables