Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !30042

Provide a standalone accordion component

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/gijsroge/standalone-accordion into main Jan 17, 2020
  • Overview 0
  • Commits 16
  • Pipelines 0
  • Changes 8

Created by: gijsroge

This adds a standalone accordion component with its own settings and markup.

Preview: https://deploy-preview-30042--twbs-bootstrap.netlify.com/docs/4.3/components/accordion/

Also added a flush and striped variation.

Fixes #30015 (closed)

Fixes #28134 (closed) by moving the border bottom from the header to a border top on the body we fix the overlapping issue where the border would be invisible if the body had a background color. This also allowed me to also remove the overflow: hidden; on the .accordion-item which fixes #28873 (closed)

Also fixes #25811 (closed)

Currently this is still a work in progress.

  • Add active state
  • Add focus state
  • Add icon based on collapsed state
  • Double check design
  • Double check code
  • Check if all conditions described in https://www.w3.org/TR/wai-aria-practices-1.1/#accordion are met
  • If these conditions are met, check if https://github.com/twbs/bootstrap/blob/master/site/content/docs/4.3/components/collapse.md#L130 is still relevant
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/gijsroge/standalone-accordion