Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !30080

Headings hierarchy in licence.md

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/ffoodd/docs/headings-hierarchy into master Jan 24, 2020
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: ffoodd

Very simple and specific improvement to the licence page, which stepped from h1 to h4.

FYI, I also noticed a few other headings hierarchy failures when using some callouts, in which heading level is defined in Markdown without taking the context of the page in which they're included.

For example, calling callout-danger-async-methods.md after a h2 will break headings hierarchy by stepping to h4.

I tried a bit but struggled with Hugo specificities: we're include a Markdown partial through a partial shortcode (why? is it only to pass context?) inside a callout shortcode. So passing an argument to handle heading level in partial isn't easy.

I don't know if I should try to handle arguments in the partial shortcode, or if I should move those callouts to .html and calling them directly with the partial method (without the partial shortcode in the middle).

I can't help more with this, but at least the Licence page is easy to imrpove :)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ffoodd/docs/headings-hierarchy