Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !30329

Mark peer dependencies as optional

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/felixfbecker/peer-dependencies-meta-v4 into v4-dev Mar 03, 2020
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: felixfbecker

This solves the log spam for people using Bootstrap without the JS functionality, with yarn. This can be annoying because not everybody on a large team knows these are harmless in their app, and it trains people to ignore other valid warnings. It only affects the display of warnings, so this is a safe change. Version compatibilities are still checked if the peer dependencies are installed.

[4/5] 🔗  Linking dependencies...
warning " > bootstrap@4.4.1" has unmet peer dependency "jquery@1.9.1 - 3".
warning " > bootstrap@4.4.1" has unmet peer dependency "popper.js@^1.16.0".

Reference: https://github.com/yarnpkg/rfcs/blob/master/accepted/0000-optional-peer-dependencies.md https://github.com/yarnpkg/yarn/blob/master/CHANGELOG.md#1130

Related issue with complains about the log spam: https://github.com/twbs/bootstrap/issues/23557

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/felixfbecker/peer-dependencies-meta-v4