Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !30358

Switch to strings constants.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged XhmikosR requested to merge master-xmr-constants-string into master Mar 07, 2020
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 12

This allows the minifier to mangle the constants. It also allows the linter to find unused strings properly.

This is an update/continuation of #21711.

Fixes #20011 (closed)

File Before After Diff
bootstrap.bundle.min.js 23.61 kB 22.61 kB -1.00 kB (-4.23 %)
bootstrap.min.js 17.04 kB 16.08 kB -0.96 kB (-5.63 %)

Preview: https://deploy-preview-30358--twbs-bootstrap.netlify.com/

TODO:

  • popover
  • tooltip
  • take care of any newly added TODO comments
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-xmr-constants-string