Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !30391

transition() mixin prevent redundant 'transition: none' and pass `null`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge master-ysds-transition-mixin into master Mar 14, 2020
  • Overview 2
  • Commits 5
  • Pipelines 0
  • Changes 1

Created by: ysds

This PR includes three points:

1. transition(null) and transition(none) output the following redundant CSS, but should be prevented.

@media (prefers-reduced-motion: reduce) {
  selector {
    transition: none;
  }
}

2. Fix the problem where libsass(node-sass) can't handle transition(null) well:

selector {
  @include transition(null);
}
// output
selector {
  transition:;
}

3. The transition mixin now show warning message when use none or null with multiple arguments.

Before: https://www.sassmeister.com/gist/b4d2d3ce8601116308e72df97a0d309a After: https://www.sassmeister.com/gist/7ddae4ab995e0b41bbb93abe6eff616f

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-ysds-transition-mixin