Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !30622

Colors rewrite

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge master-mc-colors into main Apr 20, 2020
  • Overview 3
  • Commits 4
  • Pipelines 0
  • Changes 15

Created by: MartijnCuppens

Purpose of this PR is to use a uniform approach on using colors:

  • Use tint-color() to replace lighten()
  • Use shade-color() to replace darken()
  • Use scale-color() to replace color-level() (since we don't work with levels anymore)
  • Get rid of $theme-color-interval, the 8% levels are hard to calculate with.
  • Table variants, list item variants & alerts variants used to have different colors:
    • https://twbs-bootstrap.netlify.app/docs/5.0/content/tables/#variants
    • https://twbs-bootstrap.netlify.app/docs/5.0/components/alerts/#examples
    • https://twbs-bootstrap.netlify.app/docs/5.0/components/list-group/#contextual-classes vs
    • https://deploy-preview-30622--twbs-bootstrap.netlify.app/docs/5.0/content/tables/#variants
    • https://deploy-preview-30622--twbs-bootstrap.netlify.app/docs/5.0/components/alerts/#examples
    • https://deploy-preview-30622--twbs-bootstrap.netlify.app/docs/5.0/components/list-group/#contextual-classes (color contrast on the light variants is still an issue, but can be tackled later on to prevent this PR from being too overwhelming)
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-mc-colors