Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !30680

Use `safeHTMLAttr` in the `integrity` attributes.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged XhmikosR requested to merge master-xmr-docs-hugo-safeHTMLAttr into master Apr 29, 2020
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 5

I just noticed this after testing Microsoft Edge (old Edge) and I was getting this error although the CSS did load:

SEC7136: [Integrity] The origin 'https://twbs-bootstrap.netlify.app' failed an integrity check for a style resource at 'https://twbs-bootstrap.netlify.app/docs/4.3/dist/css/bootstrap.min.css'.

It seems Hugo escapes those. Now the problem is these two:

  1. The masthead-followup.html becomes more and more unreadable IMO. But at least it does work properly.
  2. There are 2 cases we print integrity hashes in Markdown with shortcodes where I don't know how to fix the issue:
  • https://github.com/twbs/bootstrap/blob/master/site/content/docs/4.3/getting-started/download.md
  • https://github.com/twbs/bootstrap/blob/master/site/content/docs/4.3/getting-started/introduction.md

@regisphilibert: maybe you have any suggestions how to fix this? 🙂

Preview: https://deploy-preview-30680--twbs-bootstrap.netlify.app/

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-xmr-docs-hugo-safeHTMLAttr