Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !30752

Fix storing multiple data keys

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/MisatoTremor/js-fix-multiple-data-keys into main May 06, 2020
  • Overview 1
  • Commits 3
  • Pipelines 0
  • Changes 2

Created by: MisatoTremor

The current implementation does not support storing multiple sets of data (the key parameter is mostly useless), which is fixed by this PR.

As a sidenote: The data storage indices for the keys are stored on the element attribute key. HTMLElement does not use this attribute, yet, and to my knowledge no subtype does. But it is a very generic name which might be prone to collide in the future, maybe a more bootstrap specific attribute would be better.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/MisatoTremor/js-fix-multiple-data-keys