Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !30831

v5: Make navbar active links consistent

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge v5-consistent-navbar-active-links into master May 14, 2020
  • Overview 3
  • Commits 3
  • Pipelines 0
  • Changes 2

Two sets of changes:

  • Updates the navbar docs to put .active on .nav-link instead of .nav-item like the rest of our navs. Fixes #30652 (closed).

  • Removes two selectors, .active > .nav-link and .nav-link.show, because as far as I can tell, those are duplicative and unused, respectively. .active just needs to be on the .nav-link, and .show is always on the parent .nav-item because it toggles the .dropdown-menu.

Am I missing something with those two selectors? Clicking around on dropdowns in the nav shows no issues thus far.

Regarding consistency, I also just noticed that .btns get .btn.show for the dropdown-menu though. Do we consolidate and make sure .show is always on the .btn and .nav-link instead of parents? Punted to #30846.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: v5-consistent-navbar-active-links