Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !30973

Remove .nav-item from .nav-link to make it consistent

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/rohit2sharma95/consistent-nav-item into master Jun 05, 2020
  • Overview 1
  • Commits 3
  • Pipelines 0
  • Changes 4

Created by: rohit2sharma95

Remove the class .nav-item from .nav-link inside the non ul or ol based navs. This makes the consistency for .nav-item (This class will not be required on the .nav-link). .nav-item was only required when you use .nav-fill or .nav-justified on the .nav. In other cases, it was redundant. And the purpose of .nav-item on .nav-links can be achieved via flexbox utilities as well (Mentioned in the docs also).

Closes #28423 (closed) Related #30880 (closed), #28117 (closed) (This PR covers #30912 as well)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/rohit2sharma95/consistent-nav-item