Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !30984

Make jquery and popper.js optional peer dependencies

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/perrin4869/patch-1 into v4-dev Jun 09, 2020
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: perrin4869

I know this is a discussion that has been had many many times before, but I have never seen this specific solution proposed. The peerDependenciesMeta property of package.json is little known, and is not documented, but has been released in npm@6.11:

https://github.com/npm/cli/releases/tag/v6.11.0 https://npm.community/t/release-6-11-0/9572

It allows to mark certain peerDependencies as optional, opting for a middle-ground between optionalDependencies and peerDependencies. People who use bootstrap with react will benefit from this change by not having an incorrect warning about missing dependencies, and people who use bootstrap as is will continue to use it without any changes.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/perrin4869/patch-1