Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !31108

Update .rounded utilities

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Mark Otto requested to merge rounded-updates into main Jun 19, 2020
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 3
  • Adds .rounded-1, .rounded-2, and .rounded-3
  • Drops .rounded-sm and .rounded-lg because they conflict with breakpoint nomenclature
  • Rearrange rounded docs

Closes #30048, fixes #29989 (closed), closes #30778.


My hope with this PR is to balance keeping the primary .rounded class while reducing confusion around class names and adding additional control. To that end, I'm thinking of keeping .rounded even though it's the same as .rounded-1 as of right now. This then drops .rounded-sm and .rounded-lg for something else.

That last change feels maybe problematic though since our large and small inputs and buttons use those variables.

Which of the referenced PRs are the best approaches? I feel like I could go any direction...

/cc @twbs/css-review

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rounded-updates